Putty commits

RevisionAuthorDateDescription
8394jacob05 Jan 2009 19:25:07

Rejig windlg.c:verify_ssh_host_key() to silence a warning.

8393jacob05 Jan 2009 19:16:35

Remove a couple of unused variables.

8392jacob05 Jan 2009 18:49:19

It's a new year (and there have even been checkins).

8391jacob05 Jan 2009 18:36:14

sk_address_is_local() failed to cope when presented with a Unix-domain socket.
This could cause Unix PuTTY to segfault when X forwarding over an SSH session
through a proxy.
(sk_getaddr() wouldn't cope either -- in that case, add an assertion to make it
more obvious; I don't think it should ever happen.)

8390jacob05 Jan 2009 17:53:14

Be prepared for x11_setup_display() to return NULL (for instance, if DISPLAY
has invalid contents). Simply refuse to try X forwarding in this circumstance.

8389jacob05 Jan 2009 14:39:27

r5080 didn't go far enough -- since 0.58, anyone on Unix who didn't previously
have default settings for "bell overload" mode will have inherited a twitchy
set of defaults where bells are disabled after 2ms and enabled after 5ms,
rather than 2s and 5s as intended. This error has probably propagated into some
people's saved sessions by now, but there's not much to be done.

8385jacob04 Jan 2009 21:45:38

Add some hard-coded textual literal-IP representations of localhost to
sk_hostname_is_local(), to catch the case where we're doing something like X11
forwarding over SSH through a proxy, and we've thus disabled local lookup of
hostnames.
(I think this is what's behind the report in

in comp.security.ssh, although I'd like to know more of the circumstances.)

8384jacob04 Jan 2009 20:15:06

...and fix an unlikely memory leak.

8383jacob04 Jan 2009 20:01:58

Cope with a (non-standard) ENAMETOOLONG return from gethostname(); glibc will
do this if the supplied buffer isn't big enough, which shouldn't lead to
complete abandonment of X11 auth. (Would only have bitten with hostnames
>255 chars anyway.)

8382jacob04 Jan 2009 18:36:24

r8305 made platform_x11_best_transport[] obsolete, but there still seem to be a
few instances around; expunge them.

8381jacob04 Jan 2009 18:28:25

r8305 seems to have made Unix PuTTY rather over-keen on Unix-domain sockets;
unless a protocol is explicitly specified with "tcp/foovax:0", it assume a
Unix-domain socket, thus not allowing a remote display on a machine other than
the client.

8380jacob04 Jan 2009 17:24:08

Bah, I've bumped into this often enough. Change one unsatisfactory cast for
another to shut up "warning: cast from pointer to integer of different size"
(and hence a -Werror compile failure) when compiling for Unix with DEBUG
defined on atreus (x86_64). Minimally checked that it doesn't introduce upset
elsewhere (i386).

8379jacob04 Jan 2009 16:43:20

Log reason for failure to create a connection to a local X display.