Adobe Flex SDK commits

RevisionAuthorDateDescription
4410jszeto@adobe.com06 Jan 2009 17:48:36

FXG Bug Fixes

SDK-18287 RTE when trying to use databinding with FXG graphic assets

Added Bindable metadata back to FilledElement.fill and StrokedElement.stroke. These were causing RTEs because databinding was
attempting to access the fill or stroke before they were created.

SDK-17650 LinearGradient scaleX attribute doesn't work when linear gradient is rotated

When scaleX is set, we now honor the value when the gradient is rotated. Graphics.createGradientBox normally tries to "fit" the gradient into the available space when it is rotated.

SDK-17645 Data binding will not be able to detect assignments to LinearGradient rotation property

Added Bindable metadata to GradientBase.rotation

SDK-18293 mx.filters.ColorMatrixFilter matrix property needs to support a comma delimited String of values

Changed the matrix property from type Array to type Object. The underlying backing variable remains an array. The setter will convert a comma delimited string into an array. The getter will always return an array.

QE Notes: LinearGradient looks different than before when using scaleX and rotation together. Add tests for ColorMatrixFilter.
Doc Notes: Need docs for ColorMatrixFilter. Changed behavior of LinearGradient.scaleX and LinearGradient.rotation.
Bugs: SDK-18287, SDK-17650, SDK-17645, SDK-18293
Reviewer: Glenn

4407jimurphy@adobe.com06 Jan 2009 14:25:39

revert TLF back to 323. Mustella failures were uncovered that need some more investigation before we add this TLF build to the trunk

4406dloverin@adobe.com06 Jan 2009 11:50:31

Change tests that generate bits of Style-related code. Where the tests used to test for FxContainer they now test for ISimpleStyleClient. The changes only impact Gumbo applications, Flex3 and older applications will continue to be tested for LayoutContainer.

QE Notes: None
Doc Notes: None
Bugs: None
Reviewer: Paul
tests: checkintests

4405jimurphy@adobe.com06 Jan 2009 11:41:50

trunk updates:
-TLF : 339
-coretech (afe.jar & rideau.jar) : 54.370793
-blazeds_trunk (fmc.jar) : 4.0.0.4391

4404jimurphy@adobe.com06 Jan 2009 10:41:47

block 3.x rev. 4331 from being merged back up into the trunk

4403preilly@adobe.com06 Jan 2009 10:32:54

* Reverted the style related aspect of revision 4393, because it
didn't handle the situation where new dependencies, with associated
type selectors, are added via type selectors.

4394pfarland@adobe.com05 Jan 2009 16:13:51

Adding last changes and comments on behalf of Kaushal for his radial and linear gradient transform calculations.

QE: Not yet.
Doc: No
Checkintests: Pass

4393preilly@adobe.com05 Jan 2009 15:03:46

* More SWF size reduction work:

* WatcherSetupUtil classes are no longer mixins. This should remove
some String's from the generated *FlexInit class and reduce frame
1 pressure by deferring the creation of the *WatcherSetupUtil
classes until an instance of a Mxml component is created. Thanks
to Alex for reporting this problem.

* The code generated for styles defaults is now combined into a
single helper classes. This should also reduce the number of
String's in *FlexInit.

tests Passed: checkintests, mxunit databinding

Needs QA: YES

Needs DOC: NO

API Change: NO

Reviewer: Pete F.

Code-level description of changes:

compiler/as3/binding/DataBindingExtension.java

Removed MIXIN constant and modified generateWatcherSetupUtilAST()
to no longer generate the Mixin metadata.

compiler/as3/binding/WatcherSetupUtil.vm

Removed the [Mixin] metadata from the template.

compiler/css/StyleDef.vm

Modified the template to iterate over a set of StyleDef objects
instead of handling a single StyleDef object.

compiler/css/StylesContainer.java

Modified processDependencies() to collect up all the dependent
StyleDef's and AtEmbed's, then invoke generateStyleSource(), which
uses StyleDef.vm, once.

tools/PreLink.java

Modified processMainUnit() to pass the main unit's name into
processDependencies().

4392dsubrama@adobe.com05 Jan 2009 14:59:33

Nominal ASDoc typo fix to FxListBase.

4390rfrishbe@adobe.com23 Dec 2008 18:34:25

Fix a small bug with BitmapGraphic in the way it's calling the fill. Since fill now works properly, we need to make sure begin() is called correctly.

Also, I removed ITransformable yesterday, but let's push some of those properties on to IVisualElement directly.

QE Notes: The ITransformable change should fix some tests that aren't compiling in 3d layout
Doc Notes: None
Bugs: SDK-18530
Reviewer: Evtim
tests: checkintests, mustella Group tests, BitmapGraphic tests (one BitmapGraphic tests was still failing for me...)

4386rfrishbe@adobe.com23 Dec 2008 13:40:13

Ths is a regression from my checkin yesterday. If the mxmlContent hasn't been validated yet and something gets added in the interrim, we should just add it anywhere on the display list.

This isn't an optimal fix as if th mxmlContent is invalid, we probably don't need to do anything here. I'll make this optimization later.

QE Notes: We should add tests to make sure we test all these methods before proper initialization
Doc Notes: None
Bugs: SDK-18531
Reviewer: Corey
tests: checkintests, mustella Group tests

4380rfrishbe@adobe.com23 Dec 2008 05:00:21

Mostly rename changes in Group and FxContainer.

1. GraphicElement.elementHost:GroupBase -> GraphicElement.parent:DisplayObjectContainer (parent already exists in the current code-base...I’m just removing elementHost now)

2. Group content APIs now use “element” instead of “item.” The new methods were added a while ago, but the old ones co-existed. These particular changes remove the old methods and strongly type the new ones to deal with IVisualElements rather than Objects. Here are the overall changes:

numItems:int -> numElements:int
getItemAt(int):Object -> getElementAt(int):IVisualElement
addItem(Object):Object -> addElement(IVisualElement):IVisualElement
addItemAt(Object, int):Object -> addElementAt(IVisualElement, int):IVisualElement
removeItem(Object):Object -> removeElement(IVisualElement):IVisualElement
removeItemAt(int):Object -> removeElementAt(int):IVisualElement
getItemIndex(Object):int -> getElementIndex(IVisualElement):int
setItemIndex(Object, int):void -> setElementIndex(IVisualElement, int):void
swapItems(Object, Object):void -> swapElements(IVisualElement, IVisualElement):void
swapItemsAt(int, int):void -> swapElementsAt(int, int):void

3. Group and FxContainer's mxmlContent property is now strongly typed as an Array of IVisualElements instead of an Object

4. Removing ITransformable...there's no need for it.

5. Had to update Mustella for these changes (the Perforce changes are checked in, and here's the mustella.swc change for checkintests)

QE Notes: Joan and Steve worked with me on changing all the SDK QA tests.
Doc Notes: None
Bugs: SDK-18063
Reviewer: Jason
tests: checkintests, Mustella FxContainer, Group, and DataGroup (Joan ran all tests on an earlier version of these changes, so hopefully nothing broke in the meantime). Some of the Group/DataGroup ones were failing for me, but I'm pretty sure they're all excluded (tests don't seem to exclude for me when I VPN in...)

4378jszeto@adobe.com22 Dec 2008 19:24:54

BitmapFill Bug fixes and minor Group mask change

SDK-18378 BitmapFill rotation property not rotating correctly

Change code to use radians instead of angles

SDK-18345 Cannot change BitmapFill source property at runtime using ActionScript

Fixed logic in source setter

SDK-18344 Setting BitmapFill source dynamically at runtime doesnt immediately update the display list.

Dispatch PropertyChange event from source setter

* Added transformX, transformY, x, y

These properties are defined in the FXG spec, but were missing.

* Deprecated originX, originY, offsetX, offsetY

These are replaced by transformX, transformY, x, and y.

* Fixed setting source to null

* Fixed originX/Y logic

Code now translates the bitmap back

* Fixed position when sharing displayObject

Take into account the position of the bounds passed into the begin function.

* Moved Group's mask and maskType logic from commitProperties to updateDisplayList

QE Notes: Need updated tests for BitmapFill.
- add transformX, transformY, x, y.
- test setting source to null, or changing source
- test position when you have multiple GraphicElements sharing the same displayObject
- test setting rotation

Doc Notes: Need doc for transformX, transformY, x and y.
Bugs: SDK-18378, SDK-18345, SDK-18344
Reviewer: